feat: add more file type#192
Conversation
WalkthroughThe update expands the recognized file pattern lists in the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
pkg/modelfile/constants.go (4)
27-41: Broadening config file support looks good. The added generic config and XML-related extensions (*.cfg,*.conf,*.properties,*.props,*.prop,*.xml,*.xsd,*.rng) enhance flexibility. Consider alphabetically ordering this slice or grouping by type (e.g., JSON, YAML, XML, generic) to improve maintainability.
67-77: Good coverage of additional model formats. The new extensions (*.ot,*.engine,*.trt,*.onnx,*.gguf,*.msgpack,*.model,*.pkl,*.pickle,*.ckpt,*.checkpoint) encompass major frameworks. For future ease of navigation, consider sorting them alphabetically.
82-132: Extensive expansion of code file patterns. The inclusion of many new source, header, and library file extensions is comprehensive. To boost readability, you may break this large slice into sub-categories (e.g., scripts, sources, headers, binaries) or sort entries alphabetically. Also, update the slice comment to reflect that it now covers more than “script and notebook files.”
145-171: Enhanced documentation asset support. Adding logs, modern image formats (*.webp,*.heic,*.heif,*.hevc,*.svg) and video formats covers common use cases. For consistency, group and alphabetize entries within each media category (documentation, images, videos).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pkg/modelfile/constants.go(4 hunks)
🔇 Additional comments (1)
pkg/modelfile/constants.go (1)
43-48: Review tokenizer and variant patterns. The pattern*tokenizer.model*alongsideconfig.json.*covers diverse filenames but may be overly permissive—verify it matches only the intended tokenizer files (e.g.,my.tokenizer.model) and doesn’t catch unintended files.
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
aftersnow
force-pushed
the
add-unknown-media-type
branch
from
4e82fe0 to
565a02c
Compare
feat: support more file types Signed-off-by: SAY-5 <say.apm35@gmail.com>
2 participants
Summary by CodeRabbit